feat: PickHybProbeOnly() task in prymer
#50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 25 25
Lines 1597 1597
Branches 302 302
=======================================
Hits 1555 1555
Misses 23 23
Partials 19 19 ☔ View full report in Codecov by Sentry. |
emmcauley
force-pushed
the
em_feat_pick_hyb_probe
branch
from
b2a658c
to
f13f981
Compare
emmcauley
force-pushed
the
em_feat_pick_hyb_probe
branch
from
014e7bc
to
d32a7ac
Compare
|
Closing in favor of a revised #51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11.
Context
We want to be able to design internal probes as part of
prymer. This PR addsPickHybProbeOnlyas aPrimer3Task.Overall, this PR is based off
mainand highlights mostly code moving and renaming. This PR also adds some simple dataclasses:ProbeParameters()for probe design parametersProbeWeights()for penalties associated with probe paramsMore tests are required and I intend to add them in a follow-up commit. Additionally, for
Primer3to serve thermodynamic scores for primer design tasks, the thermodynamic parameters and weights need to be added toProbeParameters()andProbeWeights()(this will be in a future commit).